MType PROPRIETARY causing a gs.up.drop

hphillip · November 16, 2022, 3:40pm

I’m using

The Things Network Command-line Interface: ttn-lw-cli
Version: 3.22.2
Build date: 2022-11-10T13:51:07Z
Git commit: 33e03d104
Go version: go1.19.2
OS/Arch: windows/amd64

Since 2022-11-16T05:57:17 I’m observing frequent gs.up.drop messages of the type:

“data”: {
“@type”: “type.googleapis.com/ttn.lorawan.v3.ErrorDetails”,
“namespace”: “pkg/encoding/lorawan”,
“name”: “unknown_field”,
“message_format”: “unknown {lorawan_field}”,
“attributes”: {
“lorawan_field”: “MType”,
“value”: “PROPRIETARY”
},

It is possibly a non-compliant device (not one of mine, I hasten to add) within range of my gateway.
I’ve not noticed it prior to 3.22.2

Has anyone else noticed anything similar?

hphillip · December 6, 2022, 5:11pm

Just in case anyone else stumbles across this, the issue has been progressed here:

github.com/TheThingsNetwork/lorawan-stack

message_format for error messages with "name" : "unknown_field"

opened 11:08AM - 29 Nov 22 UTC

closed 12:34PM - 06 Dec 22 UTC

V999TEC

technical debt

### Summary The message_format of an error message is parameterised so that a t…emplate message containing {attributeName} can be substituted with corresponding attribute values. A good example is: `"name": "field_length_equal", "message_format": "`{lorawan_field}` length `{value}` should be equal to `{expected}`", "attributes": { "expected": 23, "lorawan_field": "JoinRequestPHYPayload", "value": 35 }` which can be simply parsed into `JoinRequestPHYPayload` length `35` should be equal to `23` However the message_format for "name": "unknown_field" is not so friendly: `"name": "unknown_field", "message_format": "unknown `{lorawan_field}`", "attributes": { "lorawan_field": "MType", "value": "PROPRIETARY" }` ...because the message_format does not include {value} in its string ### Current Situation This issue has been raised because since 3.21.2 I have been seeing traffic through one of my gateways that are getting frequent gs.up.drop responses due to the use of MType PROPRIETARY. Ironically my initial parsing of the message just showed unknown 'MType' so I had to dig into why the message was being dropped. According to documentation, quote: "These are typically non-LoRaWAN traffic received by a gateway on your network" unquote However, as there is a PROPRIETARY value in the MType enum, from a sematically perspective I am slightly surprised the reason for the gs.up.drop is "unknown_field". ### Desired Situation A better template for this message could be: "message_format": "unknown `{lorawan_field}` value `{value}`" I perfectly understand te reason to drop messages that are non-LoRaWAN, but perhaps there is a better way of indicating non-LoRaWAN traffic? ### Code of Conduct - [X] I agree to follow TTN's [Community Code of Conduct](https://github.com/TheThingsNetwork/Manifesto/blob/master/CodeOfConduct.md).